PEP 696: some suggestions to make the text clearer #3641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Moves TypeVarTuple discussion so the text flows better. Otherwise, it feels to me like an awkward interlude between the paragraph introducing rules and the actual rules. * Does some light grammar massaging of said introductory paragraph.
In sections where the text uses `T1` and `T2` as TypeVar names, changes the examples to use the same names.
I'm pretty sure this is backwards, as it's the opposite of what "Constraint Rules" says, and the latter makes more sense to me.
Spells out subclassing rules in the text, rather than leaning so much on the example.
Co-authored-by: Jelle Zijlstra <[email protected]>
Gobot1234
suggested changes
Feb 6, 2024
Co-authored-by: James Hilton-Balfe <[email protected]>
Gobot1234
approved these changes
Feb 8, 2024
JelleZijlstra
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP 123: Summary of changes)I've made some suggested edits to the text for readability and fixed what I think is a typo in a code example. Feel free to reject any edits that don't make sense.
cc @Gobot1234
📚 Documentation preview 📚: https://pep-previews--3641.org.readthedocs.build/